Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust ProgressReport rich text cell styling #1591

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Adjust ProgressReport rich text cell styling #1591

merged 7 commits into from
Oct 2, 2024

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Oct 1, 2024

  • More consistent font size
  • lists render better & float around the variant icon
  • Fixed line clamp in Safari
  • Variance Explanation uses same wrapper now so it line clamps & expands like the other two.
  • I increased its default width too

Screenshot 2024-10-01 at 6 50 36 PM
Screenshot 2024-10-01 at 6 50 42 PM

Safari proof:
Screenshot 2024-10-01 at 6 50 57 PM

@CarsonF
Adjust VariantResponse cells to render lists better
3b7bf89 
Although this involves hacking the list rendering and doing our own
workaround for list item styling
@CarsonF CarsonF requested a review from rdonigian October 1, 2024 23:53
rdonigian
rdonigian reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@rdonigian rdonigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of the RichTextCell, will certainly come in handy!

CarsonF added 5 commits October 2, 2024 09:49
@CarsonF
Adjust line clamping to be compatible with Safari
d27ae6d 
Trying to clamp while also floating the icon made Safari bug out.
Putting this clamp in a separate container makes it work.
Then we can just remove the container from layout with display: contents when expanded, so that the floating around the icon works.
@CarsonF
Adjust rich text to use body2 typography to match font size of other …
b2a2892 
…text cells
@CarsonF
Extract RichTextCell & use for Variance Explanation cells
95e0c96
@CarsonF
Better DX for RichText block/renderer types
f79c643
@CarsonF
Position non-expansion cells without magic number
000e304
@CarsonF CarsonF force-pushed the bugfix/progress-reports branch from 2a21319 to 000e304 Compare October 2, 2024 14:50
@CarsonF CarsonF merged commit a555d1e into develop Oct 2, 2024
3 checks passed
@CarsonF CarsonF deleted the bugfix/progress-reports branch October 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdonigian rdonigian rdonigian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarsonF @rdonigian