Dashboard Grid Layout #1586
Closed
Dashboard Grid Layout #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdch
approved these changes
Sep 12, 2024
CarsonF
requested changes
Sep 16, 2024
| sx={{ | ||
| '--unstable_DataGrid-radius': '0px', | ||
| border: 'none', | ||
| maxHeight, |
There was a problem hiding this comment.
Instead of using JS to find element height, you can use a container query.
<Box sx={{ containerType: 'size' }}>
<DataGridPro sx={{ height: '100cqh' }} />
</Box>
There was a problem hiding this comment.
The DataGrid implementation is being moved to the specific Widget (ie: TeamNewsWidget) and will be addressed there.
rdonigian
force-pushed
the
dashboard-grid
branch
2 times, most recently
from
6148b35 to
bf5a83b
Compare
rdonigian
force-pushed
the
dashboard-grid
branch
from
bf5a83b to
b854098
Compare
|
Thanks guys! Let's just merge this into #1587 to track in one PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change we're adding the ability for configurable widgets and a My Dashboard page.
The Dashboard grid uses a CSS Grid layout (defaults to 12 columns and rows). My hope is that this can also be a foundation for customizable (drag and drop and/or resizable widgets)
Monday Task