Project Workflow Events List #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmurraydavid
force-pushed
the
status-history
branch
from
0b06cbb to
2bb41c3
Compare
rdonigian
reviewed
Jul 30, 2024
rdonigian
approved these changes
Jul 31, 2024
CarsonF
requested changes
Sep 16, 2024
andrewmurraydavid
force-pushed
the
status-history
branch
from
fff1b64 to
023cf1a
Compare
|
@CarsonF I confirmed with Amy that what is the current Drawer display is what she wants. |
- Move WorkflowEvents back into scenes because it references Project specific GQL fragment / enum values - Remove fields from GQL fragment that were unused - Rename GQL fragment file to match fragment name - Decouple events from Drawer, via children - Use standard-ish props for the Drawer (aside from transition to be compatible with useDialog) - Rename StatusHistory -> WorkflowEvents so our code is consistently named - Abstract icon specifics - Use relative timestamp - Change status color to from secondary to primary. The secondary color didn't provide enough contrast to the background.
This makes more sense and matches design
Switch to flexbox at smaller screen sizes, so each cell can wrap down as needed
Obnoxiously track the actual size of the event list via a duplicate list hidden in DOM Use this along with window size to see if we need to adjust our layout to flexbox for smaller screens
CarsonF
force-pushed
the
status-history
branch
from
023cf1a to
676346b
Compare
CarsonF
changed the title
CarsonF
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday Task