Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments #1567

Merged
merged 10 commits into from
Oct 4, 2024
Merged

Comments #1567

merged 10 commits into from
Oct 4, 2024

Conversation

andrewmurraydavid
Copy link
Member

@andrewmurraydavid andrewmurraydavid commented Jul 10, 2024

src/components/Comments/CommentEdit/CommentEdit.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, I do think that later we can abstract this out as the sidebar becomes an option for other features.

src/components/Comments/CommentReply/CommentReply.tsx Outdated Show resolved Hide resolved
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge @andrewmurraydavid, great work!!

Most of these comments are just small tweaks.

src/components/Comments/CommentEdit/CommentEdit.tsx Outdated Show resolved Hide resolved
src/components/Comments/CommentEdit/CommentEdit.tsx Outdated Show resolved Hide resolved
src/components/Comments/CommentEdit/CommentEdit.graphql Outdated Show resolved Hide resolved
src/components/Comments/CommentItem/CommentItemMenu.tsx Outdated Show resolved Hide resolved
src/components/Comments/CommentItem/CommentItemMenu.tsx Outdated Show resolved Hide resolved
src/components/Comments/CommentsBar.tsx Outdated Show resolved Hide resolved
src/components/Comments/CommentsBarContext.tsx Outdated Show resolved Hide resolved
src/components/Comments/CommentsBarContext.tsx Outdated Show resolved Hide resolved
src/components/Comments/CommentsThreadList.graphql Outdated Show resolved Hide resolved
src/components/Comments/CommentsThreadList.graphql Outdated Show resolved Hide resolved
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm good with this now! 🎉

@CarsonF CarsonF merged commit 14ae4e3 into develop Oct 4, 2024
3 checks passed
@CarsonF CarsonF deleted the comments-v2 branch October 4, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants