Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress Report Media #1480

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Progress Report Media #1480

merged 4 commits into from
Sep 27, 2023

Conversation

brentkulwicki
Copy link
Contributor

@brentkulwicki brentkulwicki commented Sep 25, 2023 •
edited by sethmcknight
Loading

CarsonF
CarsonF reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Happy to huddle more on form stuff. It's surface area is non-trivial.

src/scenes/ProgressReports/EditForm/ProgressReportEdit.graphql Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/ProgressReportEdit.graphql Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/ProgressReportEdit.graphql Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/Steps/Media/MediaStep.graphql Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/Steps/Media/MediaStep.graphql Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/Steps/Media/MediaStep.tsx Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/Steps/Media/VariantMediaAccordion.tsx Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/Steps/Media/VariantMediaAccordion.tsx Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/Steps/Media/MediaInfoForm.tsx Outdated Show resolved Hide resolved
src/scenes/ProgressReports/EditForm/Steps/Media/MediaInfoForm.tsx Outdated Show resolved Hide resolved
CarsonF
CarsonF approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuge. LGTM! 🎉 Thanks for letting jump in to wrap it up.

@CarsonF CarsonF marked this pull request as ready for review September 27, 2023 18:54
@CarsonF CarsonF changed the title Media frontend Progress Report Media Sep 27, 2023
@CarsonF CarsonF enabled auto-merge September 27, 2023 18:55
@CarsonF CarsonF merged commit 9e48f05 into develop Sep 27, 2023
4 checks passed
@CarsonF CarsonF deleted the media-frontend branch September 27, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarsonF CarsonF CarsonF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentkulwicki @CarsonF