Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore current impersonation for sensitive operations #1479

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Ignore current impersonation for sensitive operations #1479

merged 2 commits into from
Sep 21, 2023

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Sep 21, 2023

Normal user flow doesn't allow this.
But there are edge cases where this could come up.

@CarsonF
Generate the list of sensitive operations dynamically from schema
387474b
@CarsonF
Ignore current impersonation for sensitive operations
1f687bd 
Normal user flow doesn't allow this.
But there are edge cases where this could come up.
andrewmurraydavid
andrewmurraydavid approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@andrewmurraydavid andrewmurraydavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big step for our security! Nice job, @CarsonF !

Base automatically changed from dynamic-sens-ops to develop September 21, 2023 23:33
@CarsonF CarsonF enabled auto-merge (squash) September 21, 2023 23:33
@CarsonF CarsonF merged commit 5bb01f1 into develop Sep 21, 2023
@CarsonF CarsonF deleted the impersonation-sens branch September 21, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmurraydavid andrewmurraydavid andrewmurraydavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarsonF @andrewmurraydavid