New Partner Detail UI with Tab View #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmurraydavid
approved these changes
Aug 24, 2023
andrewmurraydavid
suggested changes
Sep 7, 2023
andrewmurraydavid
approved these changes
Sep 14, 2023
CarsonF
requested changes
Oct 6, 2023
src/scenes/Partners/Detail/Tabs/Projects/PartnerDetailProjectsTable.tsx
Outdated
Show resolved
Hide resolved
src/scenes/Partners/Detail/Tabs/Projects/PartnerDetailProjectsTable.tsx
Outdated
Show resolved
Hide resolved
src/scenes/Partners/Detail/Tabs/Projects/PartnerDetailProjectsTable.tsx
Outdated
Show resolved
Hide resolved
adam-soltech
commented
Oct 18, 2023
adam-soltech
force-pushed
the
agl/partner-detail-new-ui
branch
from
076efa6 to
66bdad2
Compare
adam-soltech
force-pushed
the
agl/partner-detail-new-ui
branch
3 times, most recently
from
82bc927 to
25583a8
Compare
CarsonF
force-pushed
the
agl/partner-detail-new-ui
branch
from
25583a8 to
f681703
Compare
CarsonF
force-pushed
the
agl/partner-detail-new-ui
branch
from
f681703 to
ad5b9d4
Compare
CarsonF
force-pushed
the
agl/partner-detail-new-ui
branch
from
ad5b9d4 to
77e8ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Design (I will be doing a separate review with product and design around this and have a few remaining questions for them)
Some thought that came up while doing this:
In these cases I defaulted to not trying to combine these components. Even though they share some attributes and combining them would be a bit more DRY, I've seen these types of abstractions (esp. with tables being passed wildly different configs) make a confusing mess very quickly.
I do think it might be good to abstract the partner profile card, or maybe a generic flat style card since they share the same styles and more or less the same functionality (edit the card fields), but wanted to defer to the team/Carson before getting too clever.