-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed tss-react from cord-field - 3466480946 #1164
Conversation
dd89666
to
1f396fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like this. It does "clutter" the jsx a bit more, but I think it's better to have those styles close to their usage. I've often found myself asking "what does this class do" and having to jump back and forth between styling at top and usage in jsx tree.
So I'm good with this if you like it 👍
Will you squash/fixup that second commit as well? |
@CarsonF |
Yeah I'd just prefer that "clean up" commits get squashed so we are left with single purpose commits. |
bc1e2eb
to
1182a69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some comments to get started on. The idea behind each comment could be applied across the board so take a look at the meaning and see where else it could be applied.
@@ -1,59 +1,19 @@ | |||
import { Badge, Grid, TooltipProps, Typography } from '@mui/material'; | |||
import { Badge, Grid, Theme, TooltipProps, Typography } from '@mui/material'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The styling changes in this file are overly complicated and doing incorrect things. I'll expand/help later.
This lived to the end of its lifetime and died |
┆Issue is synchronized with this Monday item by Unito
┆Link To Item: https://seed-company-squad.monday.com/boards/3451697530/pulses/3466487404