Change Link to always underline

SeedCompany · Oct 16, 2024 · a386148 · a386148
1 parent fb2bd03
commit a386148
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/...nes/ProgressReports/EditForm/Steps/SubmitReportStep/ConfirmIncompleteSubmissionDialog.tsx b/...nes/ProgressReports/EditForm/Steps/SubmitReportStep/ConfirmIncompleteSubmissionDialog.tsx
@@ -66,7 +66,6 @@ const IncompleteSteps = () => {
             {steps.map(({ label: stepName, severity }) => (
               <Typography component="li" key={stepName}>
                 <Link
-                  underline="always"
                   // Carson doesn't love this logic being duplicated here,
                   // but values semantic markup more
                   to={{ search: `?step=${kebabCase(stepName)}` }}

diff --git a/src/scenes/ProgressReports/PnpValidation/PnPExtractionProblems.tsx b/src/scenes/ProgressReports/PnpValidation/PnPExtractionProblems.tsx
@@ -47,11 +47,7 @@ export const PnPExtractionProblems = memo(function PnPExtractionProblems({
             <Alert severity="info" sx={{ mb: 1 }}>
               Once these problems are fixed, the updated file needs to be
               uploaded on the{' '}
-              <Link
-                to={`/engagements/${engagement.id}`}
-                color="inherit"
-                underline="always"
-              >
+              <Link to={`/engagements/${engagement.id}`} color="inherit">
                 Planning Spreadsheet
               </Link>{' '}
               to synchronize the changes for the planned goals.

diff --git a/src/theme/overrides.ts b/src/theme/overrides.ts
@@ -140,7 +140,7 @@ export const appComponents = ({
     },
     MuiLink: {
       defaultProps: {
-        underline: 'hover',
+        underline: 'always',
         color: 'primary.main',
       },
     },