Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised PnP error message #3336

Closed
wants to merge 2 commits into from
Closed

Revised PnP error message #3336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40835d8
revised error message and added link to guide per product team request
atGit2021 Dec 5, 2024
763bf39
revised link url
atGit2021 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/pnp/extract-scripture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ export const extractScripture = (
noteCell.ref
}\` is **${totalVersesFromNoteCol}** verses, but the goal declares **${totalVerses}** verses to translate \`${
totalVersesCell.ref
}\``,
}\` For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps" target="_blank">Guide</a>`,
source: noteCell,
});
}
Expand Down
3 changes: 2 additions & 1 deletion src/components/pnp/findStepColumns.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ export function findStepColumns(
result?.addProblem({
severity: 'Error',
groups: 'The step header label is non standard',
message: `"${label}" \`${cell.ref}\` is not a standard step label`,
message: `"${label}" \`${cell.ref}\` is not a standard step label. For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps" target="_blank">Guide</a>`,
source: cell,
});
return;
Expand Down
6 changes: 4 additions & 2 deletions src/components/pnp/isGoalRow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ export const isGoalRow = (
result?.addProblem({
severity: 'Error',
groups: 'The verses to translate exceeds total verses in book',
message: `Ignoring _${maybeBook.name}_ because **${versesToTranslate}** \`${versesCell.ref}\` verses to translate exceeds the total number of verses in the book`,
message: `Ignoring _${maybeBook.name}_ because **${versesToTranslate}** \`${versesCell.ref}\` verses to translate exceeds the total number of verses in the book. For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps" target="_blank">Guide</a>`,
source: cell,
});
return validVerseCount;
Expand Down Expand Up @@ -96,7 +97,8 @@ export function addProblemMismatchScriptureAndVerseCount(
book.ref
}\` is **${parsedVerseCount}** verses, but the goal declares **${totalVerses.asNumber!}** verses to translate \`${
totalVerses.ref
}\``,
}\`. For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps#2-mismatch-between-the-planned-scripture-in-books-or-scripture-reference-column-and-the-number-of-verses-to-translate" target="_blank">Guide</a>`,
source: book,
});
}
3 changes: 2 additions & 1 deletion src/components/pnp/isGoalStepPlannedInsideProject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ export const isGoalStepPlannedInsideProject = (
`Step(s) of goal(s) are planned to be complete **after** this project's fiscal years`,
`Step(s) of _${goalLabel}_ are planned to be complete **after** this project's fiscal years`,
],
message: `_${stepLabel}_ for _${goalLabel}_ \`${cell.ref}\` is planned to be completed _FY${fiscalYear}_ which is **after** this project's fiscal years`,
message: `_${stepLabel}_ for _${goalLabel}_ \`${cell.ref}\` is planned to be completed _FY${fiscalYear}_ which is **after** this project's fiscal years. For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps" target="_blank">Guide</a>`,
source: cell,
});
}
Expand Down
3 changes: 2 additions & 1 deletion src/components/pnp/isProgressCompletedOutsideProject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export const isProgressCompletedOutsideProject = (
`Step(s) of goal(s) are marked complete **after** this project's date range`,
`Step(s) of _${goalLabel}_ are marked complete **after** this project's date range`,
],
message: `_${stepLabel}_ for _${goalLabel}_ \`${cell.ref}\` is marked completed on _${dateLabel}_ which is **after** this project ends`,
message: `_${stepLabel}_ for _${goalLabel}_ \`${cell.ref}\` is marked completed on _${dateLabel}_ which is **after** this project ends. For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps" target="_blank">Guide</a>`,
source: cell,
});
}
Expand Down
4 changes: 2 additions & 2 deletions src/components/product/pnp-product-sync.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ export class PnpProductSyncService {
groups: 'Unable to distinguish goal row to goal in CORD',
message: stripIndent`
_${goalName}_ \`${source.ref}\` is ambiguous with other rows.
Please declare the exact scripture reference
in the _My Notes_ cell \`${myNoteCell.ref}\`.
The information in \`${myNoteCell.ref}\` is insufficient or nonexistent. For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps" target="_blank">Guide</a>
`,
source,
});
Expand Down
5 changes: 4 additions & 1 deletion src/components/progress-summary/progress-summary.extractor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ export class ProgressSummaryExtractor {
: 'undetermined'
}_ \`${cells.quarter.ref}\`/\`${cells.year.ref}\`)
needs to be *at least* the quarter of this CORD report
(_${fiscalQuarterLabel(date)}_).
(_${fiscalQuarterLabel(
date,
)}_). For more information see the PnP Troubleshooting
<a href="https://github.com/SeedCompany/cord-docs/wiki/PnP-Extraction-Validation:-Errors-and-Troubleshooting-Steps" target="_blank">Guide</a>
`,
source: cells.quarter,
});
Expand Down
Loading