Change EnforceChangesetEditablePipe to use injected, request-scoped GQL context #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…QL context This wasn't possible at the time. Since then nestjs/graphql#325 has been resolved & released in v11.0.0
CarsonF
force-pushed
the
graphql/refactor-changeset-editable-context
branch
from
bfc66fa to
1fa42ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't possible at the time.
Since then nestjs/graphql#325 has been resolved & released in v11.0.0
This is better because this is a global pipe, so it runs for GQL requests & HTTP requests.
This check is easier because it doesn't assume that you are looking for a GQL context.
The ALS getter does assume this, so here we had to try/catch check for specific exception to ignore.
In general this is easier, and works now.