[EdgeDB] Polymorphic queries & Engagement Repo #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
CarsonF
force-pushed
the
edgedb/polymorphic-queries-and-engagements
branch
from
ce5cefb to
a717eed
Compare
CarsonF
force-pushed
the
edgedb/polymorphic-queries-and-engagements
branch
from
a717eed to
38657d1
Compare
This is an UGLY hack to use ResourcesHost statically
CarsonF
force-pushed
the
edgedb/polymorphic-queries-and-engagements
branch
from
38657d1 to
8919871
Compare
bryanjnelson
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__typenamefields to be EdgeDB FQN names@edgedb/generatebranchPolymorphic queries -> discriminated union types edgedb/edgedb-js#1090
Engagement.resolvefunction instead of.__typename === '...'to decouple the stringsWhat's here is working which is the main thing, but it could be better.
The QB types could still be better to allow merging shapes & automatically handling EdgeQL type intersections & TS discrimated unions. One day.
Engagementqueries | refactor service/repo layers appropriately #3219Monday Task