Refactor Engagement module / Prep for EdgeDB #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bryan Nelson <[email protected]>
Co-authored-by: Bryan Nelson <[email protected]>
Co-authored-by: Bryan Nelson <[email protected]>
…esent It won't be used with EdgeDB Co-authored-by: Bryan Nelson <[email protected]>
Move constraints & separate reads/writes into neo4j repo. Make `secure` sync. Remove unnecessary logs & try/catches & comments. Co-authored-by: Bryan Nelson <[email protected]>
This is compatible with both current messages and new standardized EdgeDB messages Co-authored-by: Bryan Nelson <[email protected]>
🗞 GraphQL SummaryView schema changes@@ -1456,10 +1456,10 @@
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
modifiedAt: DateTime!
parent: Project!
project: Project!
@@ -1469,9 +1469,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
input EngagementFilters {
endDate: DateFilter
@@ -2165,10 +2165,10 @@
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
intern: SecuredUser!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
mentor: SecuredUser!
methodologies: SecuredMethodologies!
modifiedAt: DateTime!
parent: InternshipProject!
@@ -2181,9 +2181,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
enum InternshipPosition {
Administration
@@ -2472,16 +2472,16 @@
disbursementCompleteDate: SecuredDateNullable!
endDate: SecuredDateNullable!
endDateOverride: SecuredDateNullable!
firstScripture: SecuredBoolean!
- historicGoal: SecuredString!
+ historicGoal: SecuredStringNullable!
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
language: SecuredLanguage!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
"""The latest progress report that has a report submitted"""
latestProgressReportSubmitted: SecuredPeriodicReport!
lukePartnership: SecuredBoolean!
@@ -2491,9 +2491,9 @@
The progress report due next. This is the period currently in progress.
"""
nextProgressReportDue: SecuredProgressReport!
openToInvestorVisit: SecuredBoolean!
- paratextRegistryId: SecuredString!
+ paratextRegistryId: SecuredStringNullable!
parent: TranslationProject!
"""
A list of mediums used across all of the engagement's products and their
@@ -2515,9 +2515,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
type LanguageEngagementListOutput implements PaginatedList {
"""Whether the next page exists"""
🚨 Breaking Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled all non-EdgeDB changes out of #3219
This will keep the other PR focused on only EdgeDB changes.