-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo4j] Nested Sorting + Engagement expanded usage #3226
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows sorters to be declared without a specific input, and then called in sortWith. This opens the door to nested sorting.
bryanjnelson
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
willdch
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rdonigian
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? Engagement sorters
This new functionality is driven by the need for the new UI to sort by deep fields.
Now the engagements list supports sorting by:
nameProjectFirst
- project name, then language/intern name.nameProjectLast
- language/intern name, then project name.(Yes yes I hear you thinking multi sorting. Some day.)
sensitivity
project.primaryLocation.name
language.ethnologue.code
language.registryOfDialectsCode
currentProgressReportDue.status
sorting -> sortWith
Previously we had
This still works, but now it's recommended to switch to declare the matchers/sorters separately from application in a query.
This split allows the sorters to be referenced as sub/nested sorting in other sorting calls.
Basic sorter
Each key is the sort field string that callers can pick this is a loose string, so it can be an existing field on the type or something completely new.
This hasn't changed from previous functionality.
Nested sorter
The ability to nest sorting into relationships is possible.
This is done by appending
.*
to the key.For example, the sort field could be "parent.name"
Extending other sorters
Sorters can "extend" others too.
Defined sorters have their declared matchers exposed on the
matchers
property.So they can be spread/picked/etc. into a new object.
For example, say
Manager
extendsUser
, and we want to add some sorters for that type but keep the User ones as well.https://seed-company-squad.monday.com/boards/5989610236/pulses/6766885746