-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EdgeDB] Create Producible
, Film
, EthnoArt
, and Story
schemas
#2970
Conversation
146e3a1
to
c96862e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not necessarily sold on the splitting out of all of these into their own
esdl
files now that I see the end result. A case could be made to place them all in theproducible.esdl
. Or perhaps even include them in theProducible
module even? Thoughts appreciated.
Yeah I could go either way. I'd probably lean towards one file. Idk about moving them all into the Producible
module. That would be a non-trivial name change compared to app code, but I definitely like the idea. Just not sure about how much we should be deviating at this point...
Speaking of deviation though, I wonder if we should just make Producible
extend Named
. My thought years ago was to not enforce this field, as producibles could be labeled differently, e.g. film title vs something else. This hasn't exactly played out well though. They all have a single name field right now, so it's kinda silly we don't just have it on the producible.
That certainly makes it easier:
abstract type Producible extending Resource, Mixin::Named {
overloaded name {
delegated constraint exclusive;
}
scriptureReferences: multirange<int32>;
}
type EthnoArt extending Producible;
type Film extending Producible;
type Story extending Producible;
Yeah, I was wondering if you were going to say something about that. I like it...and will make it so! |
c96862e
to
7e35aaa
Compare
7e35aaa
to
55e314f
Compare
55e314f
to
bcc7766
Compare
@CarsonF - I'm not necessarily sold on the splitting out of all of these into their own
esdl
files now that I see the end result. A case could be made to place them all in theproducible.esdl
. Or perhaps even include them in theProducible
module even? Thoughts appreciated.Monday Task
┆Issue is synchronized with this Monday item by Unito