Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly mark nullability for language properties #2963

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Nov 15, 2023

┆Issue is synchronized with this Monday item by Unito

@CarsonF CarsonF enabled auto-merge (squash) November 15, 2023 15:20
Copy link

🗞 GraphQL Summary

View schema changes
@@ -1605,17 +1605,17 @@
 type EthnologueLanguage {
   canDelete: Boolean!
 
   """ISO 639-3 code"""
-  code: SecuredString!
-  name: SecuredString!
-  population: SecuredInt!
+  code: SecuredStringNullable!
+  name: SecuredStringNullable!
+  population: SecuredIntNullable!
 
   """
   Provisional Ethnologue Code.
   Used until official ethnologue code is created by SIL.
   """
-  provisionalCode: SecuredString!
+  provisionalCode: SecuredStringNullable!
 
   """Based on the language's sensitivity"""
   sensitivity: Sensitivity!
 }
@@ -2297,9 +2297,9 @@
   """
   displayName: SecuredString!
 
   """The pronunciation of the display name"""
-  displayNamePronunciation: SecuredString!
+  displayNamePronunciation: SecuredStringNullable!
   ethnologue: EthnologueLanguage!
   firstScripture: SecuredFirstScripture!
   hasExternalFirstScripture: SecuredBoolean!
 
@@ -2313,9 +2313,9 @@
   """Whether this language has a Least Of These grant."""
   leastOfThese: SecuredBoolean!
 
   """Reason why this language is a part of the Least of These program."""
-  leastOfTheseReason: SecuredString!
+  leastOfTheseReason: SecuredStringNullable!
   locations(input: LocationListInput = {count: 25, order: ASC, page: 1, sort: "name"}): SecuredLocationList!
 
   """The real language name"""
   name: SecuredString!
@@ -2327,12 +2327,12 @@
   The language's population.
   This is either the `populationOverride` if defined
   or the ethnologue population as a fallback.
   """
-  population: SecuredInt!
+  population: SecuredIntNullable!
 
   """An override for the ethnologue's population"""
-  populationOverride: SecuredInt!
+  populationOverride: SecuredIntNullable!
 
   """List of posts belonging to the parent node."""
   posts(input: PostListInput = {count: 25, order: DESC, page: 1, sort: "createdAt"}): SecuredPostList!
 
@@ -2352,12 +2352,12 @@
   Registry of Dialects Code.
   5 digit number including leading zeros.
   https://globalrecordings.net/en/rod
   """
-  registryOfDialectsCode: SecuredString!
+  registryOfDialectsCode: SecuredStringNullable!
   sensitivity: Sensitivity!
-  signLanguageCode: SecuredString!
-  sponsorEstimatedEndDate: SecuredDate!
+  signLanguageCode: SecuredStringNullable!
+  sponsorEstimatedEndDate: SecuredDateNullable!
 
   """The earliest start date from its engagements."""
   sponsorStartDate: SecuredDate!
   tags: SecuredTags!
@@ -5202,8 +5202,19 @@
   value: Int
 }
 
 """
+An object with an integer or null `value` and additional authorization information.
+The value is only given if `canRead` is `true` otherwise it is `null`.
+These `can*` authorization properties are specific to the user making the request.
+"""
+type SecuredIntNullable implements Secured {
+  canEdit: Boolean!
+  canRead: Boolean!
+  value: Int
+}
+
+"""
 An object with an intern position `value` and additional authorization information.
 The value is only given if `canRead` is `true` otherwise it is `null`.
 These `can*` authorization properties are specific to the user making the request.
 """

🚨 Breaking Changes

  • EthnologueLanguage.code changed type from SecuredString! to SecuredStringNullable!.
  • EthnologueLanguage.name changed type from SecuredString! to SecuredStringNullable!.
  • EthnologueLanguage.population changed type from SecuredInt! to SecuredIntNullable!.
  • EthnologueLanguage.provisionalCode changed type from SecuredString! to SecuredStringNullable!.
  • Language.displayNamePronunciation changed type from SecuredString! to SecuredStringNullable!.
  • Language.leastOfTheseReason changed type from SecuredString! to SecuredStringNullable!.
  • Language.population changed type from SecuredInt! to SecuredIntNullable!.
  • Language.populationOverride changed type from SecuredInt! to SecuredIntNullable!.
  • Language.registryOfDialectsCode changed type from SecuredString! to SecuredStringNullable!.
  • Language.signLanguageCode changed type from SecuredString! to SecuredStringNullable!.
  • Language.sponsorEstimatedEndDate changed type from SecuredDate! to SecuredDateNullable!.

@CarsonF CarsonF merged commit 0946a6a into develop Nov 15, 2023
14 checks passed
@CarsonF CarsonF deleted the bugfix/lang-nulls branch November 15, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant