Improve DX with webserver and REPL when neo4j connection is not available #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions I believe the `executeRead` was throwing the error now, which was previously not correctly converted.
…without DB connection An error will be thrown if trying to access userId before loaded. You can wait for the session to be loaded by awaiting it. `await session`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of these improvements are just restoring functionality that regressed with recent neo4j upgrades.
I changed REPL to not wait for neo4j indexes or admin setup. This is almost never needed.
I changed the root admin session to be lazily loaded, so REPL can start without it.
This will load the root user ID when the DB connection becomes available.
If trying to access
session.userIdbefore DB connection is established / ID is loaded an error is thrown.await sessionwill wait for the ID to be populated, but FYI you could be waiting for forever.┆Issue is synchronized with this Monday item by Unito