Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Language/Project name to Mixin::Named #2933

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Move Language/Project name to Mixin::Named #2933

merged 1 commit into from
Nov 10, 2023

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Nov 10, 2023

This makes it easy to grab a name from a polymorphic query.
I'm hoping we can rework user to also use this. Producibles & Files can also use this.

select Resource {
  id,
  [is Mixin::Named].name
}

I think this will come in handy for Search as well.

Also added some constraints for a trimmed string, so "Foo " becomes "Foo" and " " becomes null & constraint error.
It's as a function so we could choose to apply it to more places.

┆Issue is synchronized with this Monday item by Unito

@CarsonF CarsonF requested a review from bryanjnelson November 10, 2023 03:30
@CarsonF CarsonF changed the title Move Language/Project name to Mixin::Named Move Language/Project name to Mixin::Named Nov 10, 2023
dbschema/z.named.esdl Outdated Show resolved Hide resolved
dbschema/language.esdl Show resolved Hide resolved
Copy link
Contributor

@bryanjnelson bryanjnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@CarsonF CarsonF merged commit 335626b into develop Nov 10, 2023
13 checks passed
@CarsonF CarsonF deleted the edgedb/named branch November 10, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants