Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN from missing difficulty of book #2918

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Oct 18, 2023

@atGit2021 did all the hard work of narrowing the NaN down to this function returning undefined.

undefined * x == NaN

I fixed the Psalms name from the name change, added tests to ensure our book map is exhaustive, and am returning 0 as factor when book cannot be found as a last chance safety check.

┆Issue is synchronized with this Monday item by Unito

@CarsonF CarsonF requested a review from bryanjnelson October 18, 2023 20:56
@atGit2021
Copy link
Contributor

@CarsonF why didn't it pick up the book name since both names, Psalm and Psalms, are listed, just in reverse order?

@CarsonF
Copy link
Member Author

CarsonF commented Oct 18, 2023

@CarsonF why didn't it pick up the book name since both names, Psalm and Psalms, are listed, just in reverse order?

Those other alternate names are only used when fuzzy matching with Book.named(). This is using book.name which is the always the "canonical" name.

Copy link
Contributor

@bryanjnelson bryanjnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@CarsonF CarsonF merged commit f5338e4 into develop Oct 18, 2023
14 checks passed
@CarsonF CarsonF deleted the bugfix/book-difficulty branch October 18, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants