fix bug exposed by eslint fix

SeeClickFix · Nov 6, 2024 · afbae73 · afbae73
1 parent 364beef
commit afbae73
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/addon/components/bs-modal/footer.hbs b/addon/components/bs-modal/footer.hbs
@@ -5,7 +5,7 @@
     {{else}}
       {{#if @submitTitle}}
         <Button @onClick={{@onClose}}>{{bs-default @closeTitle "Ok"}}</Button>
-        <Button @type={{bs-default @submitButtonType "primary"}} onClick={{@onSubmit}} disabled={{bs-default @submitDisabled false}}>{{@submitTitle}}</Button>
+        <Button @type={{bs-default @submitButtonType "primary"}} @buttonType="submit" onSubmit={{@onSubmit}} disabled={{bs-default @submitDisabled false}}>{{@submitTitle}}</Button>
       {{else}}
         <Button @type="primary" @onClick={{@onClose}}>{{bs-default @closeTitle "Ok"}}</Button>
       {{/if}}

diff --git a/tests/integration/components/bs-modal/footer-test.js b/tests/integration/components/bs-modal/footer-test.js
@@ -18,7 +18,7 @@ module('Integration | Component | bs-modal/footer', function (hooks) {
     assert.strictEqual(
       this.element.querySelector('.modal-footer button').getAttribute('type'),
       'button',
-      'Submit button is of type submit.'
+      'Submit button is of type button.'
     );
     assert.dom('.modal-footer button').hasText('close', 'Button title is correct.');
   });
@@ -31,7 +31,7 @@ module('Integration | Component | bs-modal/footer', function (hooks) {
     assert.strictEqual(
       this.element.querySelector('.modal-footer button:first-child').getAttribute('type'),
       'button',
-      'Submit button is of type submit.'
+      'Close button is of type button.'
     );
     assert.dom('.modal-footer button:first-child').hasText('close', 'Close button title is correct.');
     assert.dom('.modal-footer button:last-child').hasClass('btn-primary', 'Submit button is a primary button.');