FIX selection of shipping options #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the input, one shipping size and all their options are preselected. If we want to keep that shipping size, we have to unselect the unwanted options instead of selecting the wanted
provinzio
force-pushed
the
fix-selecting-shipping-options
branch
from
9deeca7
to
d7aa6b6
Compare
|
I discovered a bug where the "Fertig" button on the shipping options page isn't pressed, when "Mittel" is preselected. Running the I'll look into it. |
|
@sebthom I fixed the bug and added a try-except-clause to avoid the behavior in the future. This PR is now ready. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: fixes #292
Description of changes: Depending on the input, one shipping size and all their options are preselected. If we want to keep that shipping size, we have to click (unselect) the unwanted options instead
Furthermore the PR fixes the wrong shipping size of DHL_10.
Code inspired by @bochen87
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.