Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly selects shipping even with condition present #202

Closed
wants to merge 7 commits into from
Closed

Conversation

DreckSoft
Copy link
Contributor

Fixes #195 and likely #196
I don't think the patch will work permanently. Maybe someone finds a better solution that just adjusting the class names all the time.

DreckSoft and others added 7 commits June 2, 2023 10:57
Fixes #195 and likely #196
I don't think the patch will work permanently. Maybe someone finds a better solution that just adjusting the class names all the time.
Fixes #195 and likely #196
I don't think the patch will work permanently. Maybe someone finds a better solution that just adjusting the class names all the time.
@sebthom
Copy link
Contributor

sebthom commented Aug 29, 2023

Thanks for the PR. I won't have time for the next two weeks to review/incorporate this. Before this can be merged the build failures must be fixed. They are probably not related to your changes but probably to the fact that the action runner images got upgraded by Github.

@DreckSoft
Copy link
Contributor Author

The PR is strage cause there are way too many changes mentioned and it's only a one-line change. However it should not break the build process.

@sebthom
Copy link
Contributor

sebthom commented Aug 29, 2023

maybe you need to rebase your branch. if this doesn't work throw the fork away, fork again and create a fresh PR.

@nalt
Copy link

nalt commented Sep 4, 2023

This shipping feature seems to be changing a lot right now. I doubt .jsx-2623555103 is a stable selector. Maybe .SelectionButton?

Also, note that the website first shows a dropdown for shipping options, which is then removed and replaced by the radio buttons. However, this is not the case in all account types – in some accounts, the dropdown list stays.

@DreckSoft DreckSoft closed this by deleting the head repository Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Publishing to Mode & Beauty > Herrenbekleidung failes
3 participants