Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up music player #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clean up music player #112

wants to merge 1 commit into from

Conversation

lauwaichung
Copy link

Reason

This stuff is all very non-essential. I was just playing around with the game, wanted to add my own music in, and I noticed a couple opportunities to clean up.

Changes

  • fix shuffle
    • was shuffling a list of indices, but then ignored that list
    • now just shuffles array of tracks
  • remove null tracks
  • move update code to coroutine
    • not necessary to finish changing tracks during a single frame
  • destroy if no tracks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lauwaichung