Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random improvements #1432

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Random improvements #1432

merged 3 commits into from
Jul 13, 2024

Conversation

jbrichau
Copy link
Member

  • Fix Hotwire example to use show: instead of call: (makes this work on platforms that do no support full continuations)
  • Improve the Welcome page a bit
  • Set version to 3.5.9

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 49.09%. Comparing base (a982e66) to head (3242efd).
Report is 2 commits behind head on master.

Files Patch % Lines
...ingStarted.class/instance/renderExamplesStepOn..st 0.00% 10 Missing ⚠️
...arted.class/instance/renderDocumentationStepOn..st 0.00% 7 Missing ⚠️
...ckage/WAComponent.extension/instance/turboShow..st 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1432      +/-   ##
==========================================
+ Coverage   49.00%   49.09%   +0.08%     
==========================================
  Files        9116     9144      +28     
  Lines       80339    80567     +228     
==========================================
+ Hits        39371    39555     +184     
- Misses      40968    41012      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau merged commit d90609c into master Jul 13, 2024
18 of 24 checks passed
@jbrichau jbrichau deleted the hotwire-fix branch July 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant