throw error when creating a duplicate temporary file

SeasideSt · Feb 4, 2024 · 2816e8e · 2816e8e
1 parent 22b0950
commit 2816e8e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/...ory/Grease-Pharo100-Core.package/GRPharoPlatform.class/instance/newTemporaryFileNamed..st b/...ory/Grease-Pharo100-Core.package/GRPharoPlatform.class/instance/newTemporaryFileNamed..st
@@ -1,4 +1,7 @@
 files
 newTemporaryFileNamed: aName
 
-	^ (FileLocator temp / aName) pathString
+	| newFile |
+	newFile := FileLocator temp / aName.
+	newFile exists ifTrue: [ GRError new signal: 'A (temporary) file with name ', aName, ' already exists.' ].
+	^ newFile pathString
diff --git a/repository/Grease-Pharo100-Core.package/monticello.meta/categories.st b/repository/Grease-Pharo100-Core.package/monticello.meta/categories.st
@@ -1 +1 @@
-SystemOrganization addCategory: #'Grease-Pharo100-Core'!
+self packageOrganizer ensurePackage: #'Grease-Pharo100-Core' withTags: #()!
diff --git a/...tory/Grease-Tests-Core.package/GRPlatformTest.class/instance/testNewTemporaryFileNamed.st b/...tory/Grease-Tests-Core.package/GRPlatformTest.class/instance/testNewTemporaryFileNamed.st
@@ -1,13 +1,16 @@
 tests-files
 testNewTemporaryFileNamed
 
-	| temporaryFile |
+	| temporaryFile fileName |
+	fileName := 'GRPlatformTestTemporaryFile'.
 	[
-		temporaryFile := GRPlatform current newTemporaryFileNamed: 'test_temporary'.
+		temporaryFile := GRPlatform current newTemporaryFileNamed: fileName.
 		GRPlatform current
 			writeFileStreamOn: temporaryFile
 			do: [ :str | str nextPutAll: 'test temporary' ]
 			binary: false.
-		self assert: (GRPlatform current fileExists: temporaryFile)
+		self assert: (GRPlatform current fileExists: temporaryFile).
+		self should: [ GRPlatform current newTemporaryFileNamed: fileName ] raise: GRError.
 	] ensure: [ GRPlatform current deleteFile: temporaryFile ].
-	self deny: (GRPlatform current fileExists: temporaryFile)
+	self deny: (GRPlatform current fileExists: temporaryFile).
+
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		SystemOrganization addCategory: #'Grease-Pharo100-Core'!
		self packageOrganizer ensurePackage: #'Grease-Pharo100-Core' withTags: #()!