properly pass settings and default use in get configs when config fil… #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferelith-maker
requested review from
Dabnsky,
foodprocessor,
jfantinhardesty and
brayan-trejo
as code owners
jfantinhardesty
approved these changes
Oct 29, 2024
foodprocessor
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing config loop
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
When I changed how the getConfig function worked by passing in the settings as well as a default boolean, I forgot to update the path of missing a config file for passing in settings as well, so settings was set to True, and defaultConfig was always set to false
Checklist
Related Issues