Cloudfuse service linux cmd #338
Conversation
Dabnsky
requested review from
Ferelith-maker,
foodprocessor,
jfantinhardesty and
brayan-trejo
as code owners
cmd/service_linux.go
Outdated
| Short: "Installs the startup process for Cloudfuse. Requires elevated permissions.", | ||
| Long: "Installs the startup process for Cloudfuse which remounts any active previously active mounts on startup. elevated permissions.", |
There was a problem hiding this comment.
These descriptions should probably not refer to "the" startup process, since each call to install only affects a single mount, and we can use this command to make multiple "startup processes."
cmd/service_linux.go
Outdated
| } | ||
|
|
||
| var installCmd = &cobra.Command{ | ||
| Use: "install", |
There was a problem hiding this comment.
Since you require two arguments, the usage string should include those.
cmd/service_linux.go
Outdated
| // assumes dir is in cloudfuse repo dir | ||
| serviceData, err := collectServiceData(fmt.Sprintf("%s/setup/cloudfuse.service", dir)) | ||
| if err != nil { | ||
| return fmt.Errorf("error collecting data from cloudfuse.service file due to the following error: [%s]", err) | ||
| } |
There was a problem hiding this comment.
For deployment, we need to add the cloudfuse.service file to the list of deployed files (in .goreleaser.yaml), and something like this should work. We may need to use filepath.Dir(os.Executable()) (documented here), instead of os.Getwd() to reliably get the path we need.
| isDirEmpty := common.IsDirectoryEmpty(mountPath) | ||
| if !isDirEmpty { | ||
| return fmt.Errorf("error, the mount path provided is not empty") | ||
| // TODO: add useage output upon failure with input | ||
| } |
There was a problem hiding this comment.
I don't think we need to check this.
There was a problem hiding this comment.
cloudfuse outputs an error and will not mount if the provided mount path is not empty
cmd/service_linux.go
Outdated
| // TODO: add useage output upon failure with input | ||
| } | ||
|
|
||
| configExists := common.DirectoryExists(configPath) |
There was a problem hiding this comment.
Although this works, I don't love that DirectoryExists is checking existence for a file.
I found another place where we check if the config file exists, and we use os.Stat directly:
if _, err := os.Stat(options.ConfigFile); errors.Is(err, fs.ErrNotExist) {
return errors.New("config file does not exist")
}
| }, | ||
| } | ||
|
|
||
| var uninstallCmd = &cobra.Command{ |
There was a problem hiding this comment.
The uninstall command will have to require the mount path to know which mount's startup service we need to remove.
cmd/service_linux.go
Outdated
| err = modifySericeFile(mountPath, dir) | ||
| if err != nil { | ||
| return fmt.Errorf("error when attempting to write defaults into service file: [%s]", err.Error()) | ||
| } | ||
|
|
||
| err = modifySericeFile(configPath, dir) | ||
| if err != nil { | ||
| return fmt.Errorf("error when attempting to write defaults into service file: [%s]", err.Error()) | ||
| } |
There was a problem hiding this comment.
Since we're creating a separate service file for each mount that the user wants to mount on startup, we'll want to
- not change our template cloudfuse.service file (we should write the modified unit file data straight to the destination)
- name each new service/unit file after the mount path, so they don't conflict, and so we can find them to remove them when uninstalling
cmd/service_linux.go
Outdated
| // 2. retrieve the newUser account from cloudfuse.service file and create it if it doesn't exist | ||
|
|
||
| serviceUser := serviceData["User"] | ||
| setUser(serviceUser) |
There was a problem hiding this comment.
On Linux I don't think we need a dedicated user.
|
|
||
| //--------------- command section ends | ||
|
|
||
| func collectServiceData(serviceFilePath string) (map[string]string, error) { |
There was a problem hiding this comment.
I don't know, but I feel like these helper functions could be a lot shorter, and more readable. I feel like these details should be abstracted away by a standard library function that does most or all of this for us...
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
This adds the following commands available to the cloudfuse executable:
cloudfuse service install
cloudfuse service uninstall
Checklist
Related Issues