Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race conditions #326

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fix race conditions #326

merged 2 commits into from
Sep 20, 2024

Conversation

foodprocessor
Copy link
Contributor

Describe your changes in brief

  • When calling cacheValidate asynchronously, make sure the file hasn't already been deleted.
  • Use LoadAndDelete whenever possible when using a sync map.

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

jfantinhardesty
jfantinhardesty approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jfantinhardesty jfantinhardesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@foodprocessor foodprocessor merged commit 5906d99 into main Sep 20, 2024
17 checks passed
@foodprocessor foodprocessor deleted the fix-race-conditions branch September 20, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfantinhardesty jfantinhardesty jfantinhardesty approved these changes

@Dabnsky Dabnsky Awaiting requested review from Dabnsky Dabnsky is a code owner

@Ferelith-maker Ferelith-maker Awaiting requested review from Ferelith-maker Ferelith-maker is a code owner

@brayan-trejo brayan-trejo Awaiting requested review from brayan-trejo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foodprocessor @jfantinhardesty