Nested map tree #15
Merged
Nested map tree #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d subtree elements
This reverts commit e2ba9ee.
This is my implementation of the insert and delete and get functions for the cacheMap tree and the respective tests to go with them.
…deleteCachedDirs()
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
…tr_cache/attr_cache.go : anycontentsInCache() Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
…ssert not nils with this function call
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
…o body of if in FlushFile() Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
…return getErr in RenameFile()
…enameFile() return nil for error check on item not in cache.
foodprocessor
approved these changes
Nov 1, 2023
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
Co-authored-by: Michael Habinsky <[email protected]> Signed-off-by: David Habinsky <[email protected]>
jfantinhardesty
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace the flat map structure with a tree. This should improve performance involved looking up cached items regarding files and folders.
Summary changes:
-modified cacheMap.go to define the tree structure and functions to insert, get, and doing a mark delete and invalidate on directories.
-added cacheMap_test.go that tests the cacheMap tree structure functions
-modified attr_cache.go to reference the new tree structure instead of the flatmap
-modified attr_cache_test.go to appropriately reference the tree structure as well as made corrections to functions in attr_cache.go to make sure the tests all pass.