Merge pull request #412 from Scrivito/fix_localStorage_in_incognito

CookieConsent: Treat denied localStorage as "declined" cookie banner.
Scrivito · Jul 5, 2021 · eff89bc · eff89bc
2 parents 456029b + b4c17cf
commit eff89bc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/Components/CookieConsentContext.js b/src/Components/CookieConsentContext.js
@@ -33,5 +33,14 @@ export function useCookieConsent() {
 }
 
 function getCookieConsent() {
-  return localStorage.getItem("CookieConsent") || "undecided";
+  try {
+    return localStorage.getItem("CookieConsent") || "undecided";
+  } catch (e) {
+    if (e instanceof DOMException) {
+      // Prevent "Uncaught DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document."
+      return "declined";
+    }
+
+    throw e;
+  }
 }
diff --git a/src/Objs/Homepage/HomepageEditingConfig.js b/src/Objs/Homepage/HomepageEditingConfig.js
@@ -70,9 +70,9 @@ Scrivito.provideEditingConfig("Homepage", {
       ],
     },
     cookieConsentLink: {
-      title: "Cookie consent link",
+      title: "Privacy policy for cookie consent",
       description:
-        'If you set this link, a cookie consent box will be shown on every page. The link should point to your privacy policy. The link title defaults to "Learn more »".',
+        'If you set this link, a cookie consent box will be shown on every page. To preview the effect of this setting, please enable third-party cookies in your browser. The link title defaults to "Learn more »".',
     },
   },
   properties: [...defaultPageProperties, "showAsLandingPage"],