Added mechanism to designate arbitrary exceptions as recoverable #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
force-pushed
the
exception-descriptor
branch
from
808a432
to
38afba3
Compare
This important feature is needed because, although we have a mechanism for marking exceptions that extend RecoverableConnectorException as recoverable at the connector level, exception may need to be treated as recoverable at the resource level too. Resource implementations may not always have the luxury of creating their own exception types when relying on third party libraries.
Bilge
force-pushed
the
exception-descriptor
branch
from
38afba3
to
33b0f84
Compare
Codecov Report
@@ Coverage Diff @@
## 5.0 #56 +/- ##
============================================
+ Coverage 91.68% 92.48% +0.79%
+ Complexity 220 209 -11
============================================
Files 37 32 -5
Lines 457 439 -18
============================================
- Hits 419 406 -13
+ Misses 38 33 -5
Continue to review full report at Codecov.
|
Bilge
force-pushed
the
5.0
branch
2 times, most recently
from
ad1512c
to
56b9d03
Compare
Bilge
force-pushed
the
master
branch
2 times, most recently
from
2308bb2
to
37b143d
Compare
Bilge
force-pushed
the
master
branch
16 times, most recently
from
a592815
to
db12909
Compare
Bilge
force-pushed
the
master
branch
26 times, most recently
from
8df01f3
to
4cd4dbd
Compare
Bilge
force-pushed
the
master
branch
4 times, most recently
from
93ce095
to
5898b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This important feature is needed because, although we have a mechanism for marking exceptions that extend
RecoverableConnectorExceptionas recoverable at the connector level, exception may need to be treated as recoverable at the resource level too. Resource implementations may not always have the luxury of creating their own exception types when relying on third party libraries.On second thoughts, changing the
RecoverableConnectorExceptionbase class to aRecoverableExceptioninterface would probably be a better solution since it would permit implementations to write whatever code they need to trap the specific exception they want to promote to recoverable without any maintenance burden within Porter herself.