Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install tlog-rec-session with utmp group ownership #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justin-stephenson
Copy link
Collaborator

Enables support for SGID update-utmp functionality implemented in 60cc06f

Enables support for SGID update-utmp functionality
@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.55% when pulling 2497325 on justin-stephenson:utmp_update_group_owner into 60cc06f on Scribery:master.

@justin-stephenson
Copy link
Collaborator Author

@casantos After thinking about this more, I would prefer to install and run tlog-rec-session with tlog:tlog ownership to run with the least amount of elevated privileges and maintain consistency with previous installs. I propose building with and adding support into tlog for https://github.com/altlinux/libutempter/ which installs with utmp group ownership and will minimize the amount of utmp/wtmp code we need to add into tlog. Unfortunately, I did not think about this earlier and therefore would likely need to revert 60cc06f

I can work on the libutempter changes but it may take some additional time, do you have any concerns with this approach?

@casantos
Copy link
Contributor

Hum, using libutempter looks like a good approach. Go ahead. I will read the documentation and try to contribute with an alternate solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants