Cruft #131
Merged
Cruft #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bandophahita
commented
Feb 20, 2024
| sphinx-rtd-theme = {version = "*", optional = true} | ||
| tox = {version = "*", optional = true} | ||
|
|
||
| autodoc-pydantic = {version = "*", optional = true} |
There was a problem hiding this comment.
I move this block of deps down for easier template override handling.
perrygoy
approved these changes
Feb 26, 2024
| @@ -7,6 +7,7 @@ repos: | |||
| - id: black | |||
| language_version: python3.12 | |||
| - repo: https://github.com/astral-sh/ruff-pre-commit | |||
| # Ruff version. | |||
There was a problem hiding this comment.
you put it in there... I figured it was useful.
Comment on lines
-66
to
+69
| 1. `pip install -e .[dev]` | ||
| 1. Optional (poetry users): | ||
| 1. `poetry install --extras dev` | ||
| 1. `pip install -e .[dev]` | ||
| 1. Optional (poetry users): | ||
| 1. `poetry install --extras dev` |
There was a problem hiding this comment.
We live in 4-space indentations all our lives and somehow missed this 3-space one for years. Can we really even call ourselves Pythonistas??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cruft to help synchronize template portions of each project