Update dependencies 2024 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygoy
commented
Feb 2, 2024
screenpy/configuration.py
Outdated
Comment on lines
31
to
36
| def _parse_pyproject_toml(tool_path: str) -> dict[str, Any]: | ||
| """Parse a pyproject toml file, pulling out relevant parts for ScreenPy. | ||
| class PyprojectTomlConfig(PydanticBaseSettingsSource): | ||
| """Load setting configuration from pyproject.toml.""" |
There was a problem hiding this comment.
This was the biggest change.
Pydantic moved its settings management stuff into pydantic-settings, and changed a whole heckin' lot over there.
Some of the changes actually made things a lot easier for us, 'cause now you can just inherit from ScreenPySettings when you make your own configuration in an extension. Neat!
bandophahita
requested changes
Feb 2, 2024
bandophahita
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to do some codin', i got an error that ScreenPy required a version of Pydantic that is incompatible with the one i was trying to install.
Well let's fix that, i thought! But there was a pretty big thing to fix. This PR updates the dependencies in pre-commit and poetry, and also updates the copyright dates. Happy 2024!