Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expand/collapse icon on saved schedules #173

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

HeidiTao
Copy link
Contributor

@HeidiTao HeidiTao commented Nov 4, 2024

Description

Changed the hide button on the saved schedules page to "Show" when the schedule is collapsed; reversed the arrow directions to display the direction of the upcoming action (show-downwards, hide-upwards).
Examples:
image
image

Type of change

  • UI fix (non-breaking change which improves UI)

How Has This Been Tested?

By adding test courses to saved schedules and clicking on the show/hide button.

Test Configuration:

Node.js version: v20.16.0
Desktop/Mobile: Desktop
OS: Windows
Browser: Chrome

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

railway-app bot commented Nov 4, 2024

This PR was not deployed automatically as @HeidiTao does not have access to the Railway project.

In order to get automatic PR deploys, please add @HeidiTao to your team on Railway.

@HeidiTao HeidiTao self-assigned this Nov 5, 2024
@HeidiTao HeidiTao added the enhancement New feature or request label Nov 5, 2024
Copy link
Member

@Xavilien Xavilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xavilien Xavilien merged commit 0555888 into main Nov 6, 2024
1 check failed
@Xavilien Xavilien deleted the heidit/schedule_expand_ui branch November 6, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants