Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Begin porting to Prisma ORM, migration to TypeScript, use of static analysis (ESLint, Prettier) #102

Merged
merged 33 commits into from
Sep 23, 2023

Conversation

Lhwhatever
Copy link
Collaborator

@Lhwhatever Lhwhatever commented Apr 1, 2023

Description

Port database queries from mongoose

Closes #100 and closes #101.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Configuration:

  • Node.js version: 19.4.0
  • OS: Linux

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Lhwhatever Lhwhatever requested a review from btwj April 1, 2023 05:48
@netlify
Copy link

netlify bot commented Apr 1, 2023

Deploy Preview for stg-course failed.

Name Link
🔨 Latest commit 5aa850e
🔍 Latest deploy log https://app.netlify.com/sites/stg-course/deploys/64fa648966b4b100088fd9d8

@btwj
Copy link
Contributor

btwj commented Apr 21, 2023

Could you edit the GitHub workflow so the linting works again?
Other than that, I don't see any issues but this is a pretty big PR. Once it's merged if there are issues we can revert and fix them.

@Lhwhatever
Copy link
Collaborator Author

@btwj not sure if Dockerfile has to be updated since we hoisted some of the dependencies. Might need to add a command to generate the prisma client too. (npm run db-generate)

@Lhwhatever Lhwhatever merged commit e965498 into main Sep 23, 2023
1 of 5 checks passed
@Lhwhatever Lhwhatever deleted the honglin/prisma branch October 24, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Migrate backend code to TypeScript [Feature] Use Prisma instead of mongoose as database ORM
2 participants