Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFD-122 Fix Axe accessibility issues #110

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

mgriffin-scottlogic
Copy link
Collaborator

  • Add <main> landmarks to index pages - not strictly a problem as it depends where component used but makes it easier to test.
  • Use <figure> element instead of a <div> as role="presentation" does not officially support labels.
  • Remove role="region" from expansion panel as they should have a unique label.

Last one is the only possible controversial change, I'm not sure if there was a reason it originally had a region role?

@sdun-scottlogic
Copy link
Contributor

Tested & Approved - SD.

Add main landmarks to index pages
Use figure element as role="presentation" does not officially support labels
Remove role="region" as they should have a unique label
@mgriffin-scottlogic mgriffin-scottlogic merged commit 0ef04e5 into main Jul 17, 2024
3 checks passed
@mgriffin-scottlogic mgriffin-scottlogic deleted the sfd-122-landmark-alerts branch July 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants