578 implement multi page modals #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhinrichs-scottlogic
requested review from
chriswilty,
pmarsh-scottlogic and
AAloshine-scottlogic
chriswilty
requested changes
Feb 26, 2024
chriswilty
reviewed
Feb 27, 2024
chriswilty
reviewed
Feb 27, 2024
There was a problem hiding this comment.
One suggestion, to decouple the MultipageOverlay from our image files, else we're good to go!
Hmm, it's actually above this review comment 🤔
#838 (comment)
dhinrichs-scottlogic
added this to the [a11y] Multi Page Modals to present story line well milestone
chriswilty
pushed a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modals now new with multiple pages and fancy character images!
Closes #578
Screenshots
Notes
Concerns
Checklist
Have you done the following?