Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial k6 setup #813

Merged
merged 7 commits into from
Feb 9, 2024
Merged

Initial k6 setup #813

merged 7 commits into from
Feb 9, 2024

Conversation

kclark-scottlogic
Copy link
Contributor

@kclark-scottlogic kclark-scottlogic commented Feb 5, 2024 •
edited
Loading

Description

Initial setup PR for k6 to have first set of scenarios running properly.

Ticket #812

Screenshots

Where applicable, show screenshots of the visual changes.

Notes

  • Bullet point list with
  • any notable code changes
  • or explanations regarding this PR

Concerns

  • Bullet point list
  • with any questions
  • or concerns about this PR

Checklist

Have you done the following?

  • Linked the relevant Issue
  • Added tests
  • Ensured the workflow steps are passing

@kclark-scottlogic kclark-scottlogic added the testing Related to testing label Feb 5, 2024
@kclark-scottlogic kclark-scottlogic self-assigned this Feb 5, 2024
@kclark-scottlogic kclark-scottlogic linked an issue Feb 5, 2024 that may be closed by this pull request
K6 initial setup #812
Closed
@kclark-scottlogic kclark-scottlogic marked this pull request as ready for review February 6, 2024 15:15
pmarsh-scottlogic
pmarsh-scottlogic approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@pmarsh-scottlogic pmarsh-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice nice

chriswilty
chriswilty reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally, works a treat 👌

Just a handful of suggestions

k6/README.md Outdated Show resolved Hide resolved
k6/README.md Outdated Show resolved Hide resolved
k6/README.md Outdated Show resolved Hide resolved
k6/README.md Outdated Show resolved Hide resolved
k6/smoke.js Outdated Show resolved Hide resolved
k6/smoke.js Outdated Show resolved Hide resolved
chriswilty
chriswilty requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, forgot to submit my review as a change request

chriswilty
chriswilty reviewed Feb 9, 2024
View reviewed changes
k6/README.md
@@ -2,13 +2,13 @@

## Introduction

This readme is for how to install and us k6 for manual load testing
Grafana k6 is an open-source load testing tool that makes performance testing easy and productive for engineering teams. k6 is free, developer-centric, and extensible. In this project we are using k6 for manual load testing. The following readMe will give basic instructions on where, what and how to install and run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

chriswilty
chriswilty requested changes Feb 9, 2024
View reviewed changes
Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teeny tiny corrections in readme, but looking nice 👌

k6/README.md Outdated Show resolved Hide resolved
k6/README.md Outdated Show resolved Hide resolved
chriswilty
chriswilty approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@chriswilty chriswilty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 👍

@kclark-scottlogic kclark-scottlogic merged commit 88abeff into dev Feb 9, 2024
2 checks passed
@kclark-scottlogic kclark-scottlogic deleted the 812-k6-setup branch February 9, 2024 11:16
chriswilty pushed a commit that referenced this pull request Apr 8, 2024
@kclark-scottlogic @chriswilty
Initial k6 setup (#813)
ef9c4eb 
* Initial k6 setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarsh-scottlogic pmarsh-scottlogic pmarsh-scottlogic approved these changes

@chriswilty chriswilty chriswilty approved these changes

Assignees

@kclark-scottlogic kclark-scottlogic

Labels
testing Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

K6 initial setup
3 participants
@kclark-scottlogic @chriswilty @pmarsh-scottlogic