741 transformed messages not showing correctly #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn in the frontend
…used stuff from file
chriswilty
reviewed
Jan 26, 2024
3 tasks
chriswilty
reviewed
Feb 2, 2024
pmarsh-scottlogic
deleted the
741-transformed-messages-not-showing-correctly
branch
chriswilty
pushed a commit
that referenced
this pull request
Apr 8, 2024
* combines two separate bits of logic for winning level in processChatResponse * renames increamentNumCompletedLevels to updateNumCompletedLevels * renames ChatHistoryMessage to ChatMessageDTO * refactors getChatHistory * further refactors getChatHistory to remove immutability * refactors makeChatMessageFromDTO * removed some outdated comments * adds reminder comment and transformedMessage as propery to chatHistoryMessage * sets transformed message inn chat history * adds ability to retrieve transformed message from the dto * add the transformed info message in backend rather than frontend * adds the transformedMessageInfo to the chat response so it can be shown in the frontend * combine message transformation objects into one object * tidies random sequence transformation test * finalise random sequence transformation test * tidy up xml tagging transformation test * tidy up xml tagging transformation test with escaping * removes unnecessary test and reorders * moves no transformation into transformation test block and removes unused stuff from file * moves transform message tests into separate test file * remove isTriggered from defence object * complete message transformation test * use undefined instead of null for transofrmed messages * updates test * removes isTriggered from test to make it pass * implements undefined tricks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where transformed messages would appear differently after page refresh. A user's transformed message stays shown with the original message in bold, and the info message "xml tagging enabled, your message has been transformed" remains.
Screenshots
Notes
main ticket changes
transformedMessagewhich keeps a pre-message, message and post-message string, allowing us to render those parts of the string differently in the chat feed. The backend chat history now stores an optionaltransformedMessageof this type, which is returned to the frontend for rendering. This fixes the transformed message appearing differently after refresh.ChatHttpResponsetesting
refactoring
processChatResponsewhich were both checking if we had met the win condition.incrementNumCompletedLevelstoupdateNumCompletedLevels(this is called when we win a level. Renamed it because we don't increment if the beaten level has been beaten before.)ChatHistoryMessagetoChatMessageDTO(this is the object that is returned when the frontend requests the entire chat history)getChatHistorymethod in frontend's chatService.ts just to make it read a bit more clearly.transformedMessage,transformedMessageInfoandtransformedMessageCombinedare now packaged under one object:messageTransformation. It is an object of this type, which is now returned bytransformMessageisTriggeredproperty fromDefencebecause it wasn't being used anymore (replaced by defenceReport)Concerns
Checklist
Have you done the following?