Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

757 various visual bugs #763

Merged
merged 4 commits into from
Jan 15, 2024
Merged

757 various visual bugs #763

merged 4 commits into from
Jan 15, 2024

Conversation

pmarsh-scottlogic
Copy link
Contributor

@pmarsh-scottlogic pmarsh-scottlogic commented Jan 12, 2024

Description

  • fixes handbook scroll behaviour
  • close button on modals back to normal size
  • blue border removed from disabled back button [themedButton] in doc viewer
  • fixes chat feed scroll issue (couldn't scroll up all the way to the top of the feed)

Screenshots

handbook scroll behaviour

no scroll
image

scrolled to bottom
image

close button

image

blue border on disabled back button in docViewer

image

Checklist

Have you done the following?

  • Linked the relevant Issue
  • Added tests
  • Ensured the workflow steps are passing

@pmarsh-scottlogic pmarsh-scottlogic linked an issue Jan 12, 2024 that may be closed by this pull request
3 tasks
@pmarsh-scottlogic pmarsh-scottlogic marked this pull request as ready for review January 12, 2024 16:13
Copy link
Contributor

@gsproston-scottlogic gsproston-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, this all covers the ticket so I'm happy to approve, but would it be cheeky to change

justify-content: center;

to

justify-content: stretch;

in ChatBoxFeed.css? To fix the chat scrolling issue.

@pmarsh-scottlogic pmarsh-scottlogic merged commit e35d6cf into dev Jan 15, 2024
2 checks passed
@pmarsh-scottlogic pmarsh-scottlogic deleted the 757-various-visual-bugs branch January 15, 2024 11:57
chriswilty pushed a commit that referenced this pull request Apr 8, 2024
* fix handbook scroll problem

* fixed closed button on modals

* fixes back button border color in doc viewer

* fixes chat box scroll issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various visual bugs
2 participants