383 level 3 story adjustments #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks to show based on levelname
pmarsh-scottlogic
requested review from
heatherlogan-scottlogic,
gsproston-scottlogic and
chriswilty
Closed
gsproston-scottlogic
suggested changes
Oct 23, 2023
gsproston-scottlogic
approved these changes
Oct 23, 2023
|
@pmarsh-scottlogic I think we wanted all text to be left-aligned now, for accessibility (dyslexia) reasons. The main page headers (e.g. "Mission Information") are center-aligned, but everything else is left-aligned. This might resolve itself once you rebase on latest dev... Thanks to Doro! |
Yup, just merged dev :) |
… element rather than classname
heatherlogan-scottlogic
approved these changes
Oct 24, 2023
chriswilty
reviewed
Oct 24, 2023
chriswilty
pushed a commit
that referenced
this pull request
Apr 8, 2024
* updated level 3 mission text * replaces U+2019 right single quotation mark characters with apostrophe U+0027 * shortens long level three strings in source code * adds short mission info to level 3 * replaces missionInfoLong with missionInfoDialogue * adds formatting to dialogue * adds scroll bar to mission information and repositons close button * fixes weird scrollbar issues by allowing overlay content to take up its full height * moves scroll bar to only scroll the dialogue * run formatter * Sets handbook attacks for level 3 and adds a map to select which attacks to show based on levelname * Updates secret documents * Updates project piglet to include mission critical information * changes the level instructions to use newhire@scottBru rather than newhire@ScottLogic * updates level3 win condition * make piglet document brief more consice * adds scottbru manager as the speaker for the sandbox information * undo changes to overlay * updates level 3 system prompt to make it more secure * updates project homer description * updates email unit tests to acccount for new level 3 win conditions * runs formatter * runs formatter on backend * fixes typo in batman document * changes liters to litres * remove percentages from 0 paddings * removes unnecessary css rule for mission information * corrects the email recipient in unit test * renames email unit tests to be more human-readable * fixed typo in DEFINED_DICTIONARY_ATTACK * changes overflow:overaly to auto * fixes incorrect heading, indents first line of dialogue text * makes indentationn in Levels.ts uniform * changes speaker back to a header element and now selects according to element rather than classname * makes css sectors for mission information morer specific * remove div selector on css rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completes #383
Changes:
speakerand sometextNotes:
Mission info is now shown as dialogue. This is the info for level 3
Here's how the mission info looks on small screens.
