run defence detection and chat completion concurrently #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heatherlogan-scottlogic
requested review from
chriswilty,
gsproston-scottlogic,
pmarsh-scottlogic and
dhinrichs-scottlogic
chriswilty
approved these changes
Oct 10, 2023
| wonLevel: false, | ||
| }; | ||
| const message = req.body.message; | ||
| const currentLevel = req.body.currentLevel; |
There was a problem hiding this comment.
Destructuring is neater:
const { message, currentLevel } = req.body;
| ...openAiReply.defenceInfo.triggeredDefences, | ||
| ]; | ||
| // combine blocked | ||
| chatResponse.defenceInfo.isBlocked = openAiReply.defenceInfo.isBlocked; |
There was a problem hiding this comment.
In general, I'm a little concerned about this mutable chatResponse object being passed around, and modified as a side-effect, as it feels like a difficult-to-detect bug waiting to emerge, particularly in functions with high complexity such as these. I am having difficulty seeing all the places it can be modified, and in what order.
I'll add a future issue to tackle this complexity, and introduce immutability.
gsproston-scottlogic
approved these changes
Oct 17, 2023
chriswilty
pushed a commit
that referenced
this pull request
Apr 8, 2024
* run defence detection and chat completion concurrently * split up chat request * refactor error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ticket
in the chat endpoint (in router.ts), split logic for level 1 and 2 (where no defences are applied), and level 2 and 3 (where we detect defences and can block message if turned on)
for level 2 and 3, call detectTriggeredDefences and chatGptSendMessage in parallel
when both are resolved, check if message was blocked in detectTriggeredDefences
if it is blocked, restore the chat history object from before the chat was sent (essentially undoing the chat message as we now find out it was blocked)
set the openAi reply to stop the message being returned to the user
testing
repeated this conversation in dev and this refactored version spy-logic-chat-log-sandbox.pdf
recorded time for whole endpoint to return with each input prompt refactor_time_comparison.ods
on average saving almost 5 seconds
comments