269 group defences #318
269 group defences #318
Conversation
gsproston-scottlogic
requested review from
heatherlogan-scottlogic
and removed request for
heatherlogan-scottlogic
|
@heatherlogan-scottlogic Just noticed a bug, working on it now |
gsproston-scottlogic
force-pushed
the
269-group-defences
branch
from
b40ac36 to
7ec146f
Compare
| /* | ||
| * Modified from https://www.w3schools.com/howto/howto_css_switch.asp | ||
| */ | ||
|
|
||
| /* The switch - the box around the slider */ | ||
| .switch { |
There was a problem hiding this comment.
Can't help thinking a checkbox would be so much simpler than a homegrown slider. This is a whole heap of css...
There was a problem hiding this comment.
This bit isn't really added in this PR, I was just moving the comment to a more suitable place. Could maybe put it in it's own component to hide it away? But I'd prefer for that work to be in a new ticket as it's not really to do with this one.
There was a problem hiding this comment.
Yes understood! Was just a comment in passing. Think we could add an issue for it though, it's really unwise to overcomplicate things. If we are going to overhaul the UI, we might consider a component library instead of home-cooking all our own.
For the collapsible sections in the control panel
| ))} | ||
| </div> | ||
| )} | ||
| </article> |
There was a problem hiding this comment.
Oh this is looking much better, nice use of article 👍
* Grouped defences * Better html grouping * Removed strategy box * Visually clearer grouping * Rounded corners on control section * Using some rather than find * Using details html elements For the collapsible sections in the control panel * Better html DRY principles
No description provided.