Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move info message to overlay #334

Closed
heatherlogan-scottlogic opened this issue Sep 29, 2023 · 3 comments · Fixed by #345
Closed

move info message to overlay #334

heatherlogan-scottlogic opened this issue Sep 29, 2023 · 3 comments · Fixed by #345
Labels
frontend Requires work on the frontend ui design Requires UI design input

Comments

@heatherlogan-scottlogic
Copy link
Contributor

heatherlogan-scottlogic commented Sep 29, 2023

Currently we have the information message and success message (when user wins) all appear in the chat box.
We will move these to an overlay with the story element to flow thorugh the apps.

Exact designs still TBC

what it looks like now:

Image

story WIP
https://docs.google.com/presentation/d/1VnRKvmhCk5nI7Tg3Jg9x1ciR4wXIooxuujo2K2WYTXs/edit#slide=id.g285d5b30fbe_0_284

  • changed this ticket to only be information message in overlay as we might combine information and success message.
    Makes sense to leave the success message as is for now

Scope of ticket

when a user clicks a new level, the info message overlay will appear.

(user can view the information from the handbook) UPDATE - new ticket to remove the mission info from handbook #395

@heatherlogan-scottlogic heatherlogan-scottlogic added frontend Requires work on the frontend ui design Requires UI design input labels Sep 29, 2023
@heatherlogan-scottlogic heatherlogan-scottlogic added this to the Handbook milestone Sep 29, 2023
@heatherlogan-scottlogic heatherlogan-scottlogic changed the title move success message and info message to overlay move info message to overlay Oct 2, 2023
@heatherlogan-scottlogic heatherlogan-scottlogic changed the title move info message to overlay move info message to handbook Oct 2, 2023
@heatherlogan-scottlogic heatherlogan-scottlogic linked a pull request Oct 4, 2023 that will close this issue
@gsproston-scottlogic
Copy link
Contributor

This hasn't been tested.

@asaha-scottlogic
Copy link

looks ok

Image

a quick query - can we also get rid of this overl;ay by clicking outside the overlay, i thought the x button was put in for this purpose, an accidental click outside the overlay take it off, not friendly.

@gsproston-scottlogic @PuneetLoona @chriswilty @heatherlogan-scottlogic

@gsproston-scottlogic
Copy link
Contributor

looks ok

Image

a quick query - can we also get rid of this overl;ay by clicking outside the overlay, i thought the x button was put in for this purpose, an accidental click outside the overlay take it off, not friendly.

@gsproston-scottlogic @PuneetLoona @chriswilty @heatherlogan-scottlogic

Yes a click outside the overlay is expected to close it. 'X' button is for accessibility (keyboard only users cannot click outside the overlay). I feel like clicking off an overlay to close it is pretty standard behaviour, and the user can always bring it back up.

@heatherlogan-scottlogic heatherlogan-scottlogic changed the title move info message to handbook move info message to overlay Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires work on the frontend ui design Requires UI design input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants