Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator options - merge to master #160

Merged
merged 10 commits into from
Feb 2, 2023
Merged

Conversation

ms14981
Copy link
Contributor

@ms14981 ms14981 commented Feb 1, 2023

I've raised #162 to move generate.js back to its original location, which represents option 4 below, so that we can sort the file locations out properly in #158 without having to worry about it in this PR, which can then have a reduced scope (the generator-options command)

BREAKING CHANGES: This will need updates to the JS and TS generator for those generators to continue working.

Possible routes forward:

  1. Make PRs for the JS and TS changes, and merge at the same time.
  2. Address The relative paths to generate.js and log.js in the forge project are hardcoded in the generators #158 first.
  3. Split out the commits that moves the generate.js file and merge only what's needed for the generator-options command.
  4. Put log.js and generate.js back in their original locations.

@ColinEberhardt ColinEberhardt merged commit bfa18e3 into master Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ColinEberhardt ColinEberhardt deleted the generator-options branch October 26, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants