Package config with dynamic package name processing + more #14
Conversation
| const shell = require("shelljs"); | ||
| const model_fix = require("./postProcessModel"); | ||
|
|
||
| module.exports = (folder, _, options) => { |
There was a problem hiding this comment.
Were we going to put formatting under the banner of post-processing? This would have the benefit of the main forge only needing to know about post-processing in general, not formatting. Although this would need changes to the other generators, I don't think those changes will be very significant.
There was a problem hiding this comment.
I agree that formatting is actually a post-processing stage and it would make sense every language to do their formating in this stage. And I also agree that it's not a big change either. Maybe we can discuss this change over the demo meeting.
There was a problem hiding this comment.
I realise that we didn't end up chatting about this. Did you want to message Colin about this?
There was a problem hiding this comment.
True, we forgot to chat about this. And since the post-processing is already merged at the main repo alongside with formatting, we can keep the logic as is in this PR at least. I can open a ticket/issue to track the merge of formatting into post-processing.
|
check #22 |
This PR is similar to #9 but includes the post-processing step to generate the dynamic folder structures.
Warning: This PR currently relies on a PR in the main forge (ScottLogic/openapi-forge#172). Merging this PR is not recommended until the said PR on main forge is merged.
Additionally, thanks to the post-processing, it is possible to split the model into seperate files without altering the forge generation structure. This PR also includes a temporary way of dealing with such situation.