Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "GitlabClaBotLoggingBucket already exists" #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maoo
Copy link
Contributor

@maoo maoo commented Feb 11, 2020

The serverless deploy command always fails (except the first time) with the error:

  An error occurred: GitlabClaBotLoggingBucket - finos-gitlab-cla-bot-logs already exists.

Using https://www.npmjs.com/package/serverless-plugin-existing-s3 to work around the issue

The `serverless deploy` command always fails (except the first time) with the error:

```
  An error occurred: GitlabClaBotLoggingBucket - finos-gitlab-cla-bot-logs already exists.
```

Using https://www.npmjs.com/package/serverless-plugin-existing-s3 to work around the issue
@sehaswell
Copy link
Contributor

Interesting that you have experienced this issue - my serverless seemed not to have trouble tearing down or replacing the old bucket.

I'm not sure I understand this fix - it looks to me like you're listing events on an existing bucket as something that should trigger the lambda. If you do this, does it not perpetually trigger itself?

What now happens on first deploy? And on teardown?
The bucket is no longer part of this serverless deployment so it won't be created or removed with it. If we go with this then the README needs instructions to create and manage one's own bucket.

What we do on this PR might resolve #31

@maoo
Copy link
Contributor Author

maoo commented Feb 11, 2020

Good points. I haven't tested first deploy or teardown, but seems that the plugin aims to address issues described on #31 . Happy to keep this PR open until that issue is tackled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants