You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Committer finder returns early upon finding a user with no e-mail, without attempting to resolve the e-mails of other users.
This proposed unit test for committerFinder shows this:
// TODO: do we need to get info on both users at once?
// committerFinder exits after finding a missing e-mail - is missing e-mail likely, or even possible?
it("will inform us about multiple unresolved users if they are unresolvable in different ways", async function() {
let unresolvableMocks = {};
unresolvableMocks.gitlabRequest = gitlabApiMocks.gitlabRequest;
unresolvableMocks.getCommits = function(projectId, mergeRequestId) {
return [noEmailBobCommit, unmappedEmailCommit];
};
unresolvableMocks.getUserInfo = gitlabApiMocks.getUserInfo;
mock("../src/gitlabApi", unresolvableMocks);
const committerFinder = mock.reRequire("../src/committerFinder");
let response = await committerFinder(
goodProjectId,
goodMergeRequestId,
goodGitlabToken
);
let expectedResponse = {
unresolvedLoginNames: [noEmailBobCommit.author_name, unmappedEmailCommit.author_name],
distinctUsersToVerify: []
};
expect(response).toEqual(expectedResponse);
});
The text was updated successfully, but these errors were encountered:
Committer finder returns early upon finding a user with no e-mail, without attempting to resolve the e-mails of other users.
This proposed unit test for committerFinder shows this:
The text was updated successfully, but these errors were encountered: