Skip to content

Commit

Permalink
Remove commented out unit test that is now accounted for in issue #46
Browse files Browse the repository at this point in the history
  • Loading branch information
sehaswell committed Mar 2, 2020
1 parent 70f7cf6 commit 305ca66
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions spec/committerFinderSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -505,30 +505,4 @@ describe("committer finder", () => {

expect(response).toEqual(expectedResponse);
});

// TODO: do we need to get info on both users at once?
// committerFinder exits after finding a missing e-mail - is missing e-mail likely, or even possible?
// it("will inform us about multiple unresolved users if they are unresolvable in different ways", async function() {
// let unresolvableMocks = {};
// unresolvableMocks.gitlabRequest = gitlabApiMocks.gitlabRequest;
// unresolvableMocks.getCommits = function(projectId, mergeRequestId) {
// return [noEmailBobCommit, unmappedEmailCommit];
// };
// unresolvableMocks.getUserInfo = gitlabApiMocks.getUserInfo;

// mock("../src/gitlabApi", unresolvableMocks);
// const committerFinder = mock.reRequire("../src/committerFinder");
// let response = await committerFinder(
// goodProjectId,
// goodMergeRequestId,
// goodGitlabToken
// );

// let expectedResponse = {
// unresolvedLoginNames: [noEmailBobCommit.author_name, unmappedEmailCommit.author_name],
// distinctUsersToVerify: []
// };

// expect(response).toEqual(expectedResponse);
// });
});

0 comments on commit 305ca66

Please sign in to comment.